net/usrsock: Add flags to sendto/recvfrom in usrsock #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,6 +172,7 @@ static int do_sendto_request(FAR struct usrsock_conn_s *conn, | |||
|
|
|||
| req.head.reqid = USRSOCK_REQUEST_SENDTO; | |||
| req.usockid = conn->usockid; | |||
| req.flags = flags; | |||
There was a problem hiding this comment.
Please submit the related patch to:
apps/examples/usrsocktest/
apps/wireless/gs2200m/
apps/netutils/usrsock_rpmsg/
There was a problem hiding this comment.
Okay, I'll push them later.
| @@ -376,9 +377,13 @@ ssize_t usrsock_sendto(FAR struct socket *psock, FAR const void *buf, | |||
| goto errout_unlock; | |||
| } | |||
|
|
|||
| /* MSG_DONTWAIT is only use in usrsock. */ | |||
|
|
|||
| flags &= ~MSG_DONTWAIT; | |||
There was a problem hiding this comment.
Should we need handle DONTWAIT like NONBLOCK flag?
| @@ -397,9 +399,13 @@ ssize_t usrsock_recvfrom(FAR struct socket *psock, FAR void *buf, size_t len, | |||
|
|
|||
| usrsock_setup_datain(conn, inbufs, ARRAY_SIZE(inbufs)); | |||
|
|
|||
| /* MSG_DONTWAIT is only use in usrsock. */ | |||
|
|
|||
| flags &= ~MSG_DONTWAIT; | |||
There was a problem hiding this comment.
Should we need handle DONTWAIT like NONBLOCK flag?
|
please add comiit message with the commit description |
Add flags argument into sendto() and recvfrom() APIs for MSG_* flags can handling in the daemon. However, MSG_DONTWAIT should process in usrsock, so it unnecessary to pass to the daemon like O_NONBLOCK.
SPRESENSE
force-pushed
the
add-flags-sendto-recvfrom
branch
from
1e34422
to
31b0a80
Compare
|
@jerpelea I added the commit message. Could you please review this? |
|
@SPRESENSE Thanks for adding the commit message |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add flags argument to sendto/recvfrom interface in usrsock.
Impact
Testing
Tested by spresense:wifi