Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: imxrt: Fix ethernet configuration in Kconfig #1527

Merged
merged 1 commit into from Aug 7, 2020
Merged

arch: imxrt: Fix ethernet configuration in Kconfig #1527

merged 1 commit into from Aug 7, 2020

Conversation

masayuki2009
Copy link
Contributor

Summary

  • Fix typo in Kconfig so that we can configure IMXRT_ENET_NRXBUFFERS.

Impact

  • imxrt family with ethernet configuration

Testing

  • imxrt1060-evk:netnsh

@masayuki2009
Copy link
Contributor Author

Hmmm,

There are build errors in esp32-core:netnsh which is not affected by this PR.

Cleaning...
Configuring...
Building NuttX...
Normalize esp32-core/netnsh
30d29
< CONFIG_MAX_WDOGPARMS=2
Saving the new configuration file
HEAD detached at pull/1527/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

modified:   boards/xtensa/esp32/esp32-core/configs/netnsh/defconfig

@masayuki2009
Copy link
Contributor Author

Hmmm,

There are build errors in esp32-core:netnsh which is not affected by this PR.

Cleaning...
Configuring...
Building NuttX...
Normalize esp32-core/netnsh
30d29
< CONFIG_MAX_WDOGPARMS=2
Saving the new configuration file
HEAD detached at pull/1527/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

modified:   boards/xtensa/esp32/esp32-core/configs/netnsh/defconfig

I've just sent a new PR to fix.

#1528

@btashton
Copy link
Contributor

btashton commented Aug 7, 2020

Hmmm,

There are build errors in esp32-core:netnsh which is not affected by this PR.

Cleaning...
Configuring...
Building NuttX...
Normalize esp32-core/netnsh
30d29
< CONFIG_MAX_WDOGPARMS=2
Saving the new configuration file
HEAD detached at pull/1527/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

modified:   boards/xtensa/esp32/esp32-core/configs/netnsh/defconfig

I've just sent a new PR to fix.

#1528

It's merged now. Feel free to rebase this one and it should pass.

@masayuki2009
arch: imxrt: Fix ethernet configuration in Kconfig
91fc5c4 
Summary:
- Fix typo in Kconfig so that we can configure IMXRT_ENET_NRXBUFFERS.

Impact:
- imxrt family with ethernet configuration

Testing:
- imxrt1060-evk:netnsh

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
@masayuki2009
Copy link
Contributor Author

@btashton

Thanks, the check build passed.

@btashton btashton merged commit b483d0d into apache:master Aug 7, 2020
@masayuki2009 masayuki2009 deleted the fix_imxrt branch August 11, 2020 00:38
@btashton btashton added this to To-Add in Release Notes - 10.0.0 Oct 14, 2020
@btashton btashton moved this from To-Add to Added in Release Notes - 10.0.0 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 10.0.0
Added
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masayuki2009 @btashton