risc-v/mmu: Fix L3 mappings for kernel, and mpfs protected mode user space #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masayuki2009 I know you use the qemu-rv / rv-virt target, I cannot test / verify that because I don't have the environment set up. If it breaks can you please inform me and I'll fix it. |
pussuw
force-pushed
the
rv_mmu_l3_fix
branch
from
7ff47d1
to
ca8c2fe
Compare
|
@pussuw |
Sounds good! |
|
@pussuw |
masayuki2009
approved these changes
Sep 10, 2022
Excellent, thank you! |
pkarashchenko
approved these changes
Sep 10, 2022
…pace The L3 mapping function was just way too simplistic. Depending on memory configuration it either works or not. Noticed that with icicle:pnsh the software crashes due to instruction page fault, reason is the map_region() implementation that does not work for regions that are not aligned to 2MB (the L2 page size). Implemented an extremely simplistic page table allocator for the L3 references, that should once and for all get rid of the L3 mapping issue. NOTE: gran_alloc() cannot be used at this point, it is too early for it.
pussuw
force-pushed
the
rv_mmu_l3_fix
branch
from
ca8c2fe
to
3cc5a17
Compare
pkarashchenko
changed the title
pkarashchenko
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The L3 mapping function was just way too simplistic. Depending on memory configuration it either works or not.
Noticed that with icicle:pnsh the software crashes due to instruction page fault, reason is the map_region() implementation that does not work for regions that are not aligned to 2MB (the L2 page size).
Implemented an extremely simplistic page table allocator for the L3 references, that should once and for all get rid of the L3 mapping issue.
NOTE: gran_alloc() cannot be used at this point, it is too early for it.
Impact
Fixes full system crash if the kernel memory regions (or user memory regions in protected mode) are selected so that they
are not aligned to 2MB boundary.
Testing
icicle:pnsh / icicle:knsh