stm32h7\stm32_fdcan_sock: reserve space for timeval struct in the int… #7194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ermediate storage of tx and rx CAN frames when timestamp is enabled
Summary
When CONFIG_NET_TIMESTAMP is enabled, can_callback() concatenates a timestamp timeval to the receive frame in the rx_pool buffer. stm32h7 does not reserve space for the extra timeval structure in the rx_pool when timestamp is enabled.
Impact
This causes a buffer overflow in the receive buffer (rx_pool).
Testing
Tested functionality on STM32H7 board with both CAN instances initialized and buffer overflow is fixed after the change.