New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp32: Add support to Quadrature Encoder #7328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acassis
force-pushed
the
esp32_qe
branch
2 times, most recently
from
October 16, 2022 15:39
591f238
to
8e6bcb2
Compare
Please ping me when all changes are applied. Also please squash commints |
Reviewed-by: Petro Karashchenko <petro.karashchenko@gmail.com>
Reviewed-by: Petro Karashchenko <petro.karashchenko@gmail.com>
pkarashchenko
approved these changes
Oct 16, 2022
tmedicci
reviewed
Oct 17, 2022
tmedicci
reviewed
Oct 17, 2022
tmedicci
reviewed
Oct 17, 2022
tmedicci
reviewed
Oct 17, 2022
tmedicci
reviewed
Oct 17, 2022
tmedicci
reviewed
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to Quadrature Encoder
Impact
Users will be able to use QE and Rotary Encoder with NuttX on ESP32
Testing
esp32-devkitc