Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32s2/i2s: use internal buffer to handle multiple audio formats #7537

Merged

Conversation

tmedicci
Copy link
Contributor

@tmedicci tmedicci commented Nov 6, 2022

Summary

Very similar to #7501:

  1. Creates an internal buffer handled by the ESP32-S2's I2S driver to be able to make the necessary manipulations to correctly fit the characteristics of the I2S's FIFO (byte alignment according to the data width).
  2. Stops and restarts I2S peripheral every time master clock and sample rate are changed.
  3. Other small fixes (like using nxmutex instead nxsem and formatting).

Impact

Supporting multiple sample rates, data widths and mono/stereo sources.

Testing

Hardware testing with ESP32-S2-Saola-1 + CS4344 and internal CI

@xiaoxiang781216 xiaoxiang781216 merged commit 998b726 into apache:master Nov 7, 2022
@jerpelea jerpelea added this to To-Add in Release Notes - 12.0.0 Dec 29, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.0.0 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants