Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/http_util): Remove sensitive header like Set-Cookie #2664

Merged
merged 2 commits into from
Jul 18, 2023
Merged

feat(core/http_util): Remove sensitive header like Set-Cookie #2664

merged 2 commits into from
Jul 18, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 18, 2023

Fix #2661

@Xuanwo
feat(core/http_util): Remove sensitive header like Set-Cookie
050a7d0 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix typo
3895ba6 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@suyanhanx suyanhanx merged commit f1b132d into main Jul 18, 2023
73 checks passed
@suyanhanx suyanhanx deleted the fix-security branch July 18, 2023 08:19
@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

security: Remove set-cookie from error output
2 participants
@Xuanwo @suyanhanx