Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Setup protoc in rust builder #2674

Merged
merged 4 commits into from
Jul 20, 2023
Merged

ci: Setup protoc in rust builder #2674

merged 4 commits into from
Jul 20, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 20, 2023

Add a step in the rust environment setup action to set up the protoc compiler. Currently used by tikv and etcd services.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

Any service who need this?😯Should we use a variable to enable it or not?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 20, 2023

Any service who need this?hushedShould we use a variable to enable it or not?

tikv and etcd.

@suyanhanx
Copy link
Member

Any service who need this?hushedShould we use a variable to enable it or not?

tikv and etcd.

😅Need a ticket to the infra...

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 20, 2023

Need a ticket to the infra...

Let's make this work simple.

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 07a4b39 into main Jul 20, 2023
27 checks passed
@Xuanwo Xuanwo deleted the add-protoc branch July 20, 2023 04:13
@oowl oowl mentioned this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants