Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add fuzz target for writer #2706

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Jul 24, 2023

part of: #2551

also split reader and range reader, ref: #2609 (comment)

Signed-off-by: dqhl76 <dqhl76@gmail.com>
Signed-off-by: dqhl76 <dqhl76@gmail.com>
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76 dqhl76 changed the title feat: add fuzz target for writer feat(test): add fuzz target for writer Jul 24, 2023
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM!

core/fuzz/fuzz_reader.rs Outdated Show resolved Hide resolved
@dqhl76 dqhl76 marked this pull request as draft July 24, 2023 10:13
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76 dqhl76 marked this pull request as ready for review July 25, 2023 01:46
@dqhl76
Copy link
Member Author

dqhl76 commented Jul 25, 2023

I reviewed libfuzzer's guide. It request us to minimize the fuzz target. So I split range reader to a individual fuzz target.
https://llvm.org/docs/LibFuzzer.html#id23

@dqhl76 dqhl76 requested a review from Xuanwo July 25, 2023 01:57
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 007565b into apache:main Jul 25, 2023
24 checks passed
@oowl oowl mentioned this pull request Jul 28, 2023
@dqhl76 dqhl76 deleted the fuzz-writer branch August 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants