Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cos multipart uploads write #2712

Merged
merged 2 commits into from
Jul 26, 2023
Merged

feat: cos multipart uploads write #2712

merged 2 commits into from
Jul 26, 2023

Conversation

parkma99
Copy link
Contributor

close #2701

@parkma99
Copy link
Contributor Author

I am confusing how to test?

suyanhanx
suyanhanx reviewed Jul 26, 2023
View reviewed changes
core/src/services/cos/writer.rs Outdated Show resolved Hide resolved
core/src/services/cos/core.rs Show resolved Hide resolved
@parkma99 parkma99 marked this pull request as ready for review July 26, 2023 02:34
@parkma99 parkma99 requested a review from Xuanwo as a code owner July 26, 2023 02:34
@oowl
Copy link
Member

oowl commented Jul 26, 2023

I am confusing how to test?

If you enable the right flag in https://github.com/apache/incubator-opendal/blob/main/core/src/services/cos/backend.rs#L282, All tests will start.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 26, 2023 •
edited

I am confusing how to test?

You can't run cos integration tests due to GitHub's limitations in this PR. Because you can't use the secrets we configured.

I will test it later this afternoon.

Xuanwo
Xuanwo approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

@Xuanwo Xuanwo merged commit 332cdb8 into apache:main Jul 26, 2023
25 checks passed
@parkma99 parkma99 deleted the feat/impl_cos_multipart_uploads_write branch July 26, 2023 06:54
@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cos: migrate to multipart uploads write
4 participants
@parkma99 @oowl @Xuanwo @suyanhanx