Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scheme from_str missing redb and tikv #2766

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix: scheme from_str missing redb and tikv #2766

merged 2 commits into from
Aug 3, 2023

Conversation

Ranxy
Copy link
Contributor

@Ranxy Ranxy commented Aug 3, 2023

Fixed the problem that redb and tikv were missing from the scheme from_str function

@Ranxy Ranxy requested a review from Xuanwo as a code owner August 3, 2023 03:28
oowl
oowl approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your point, I forget to change it.

@Ranxy
Copy link
Contributor Author

Ranxy commented Aug 3, 2023

Wait, I just realized that there seem to be others that were also missed

@oowl
Copy link
Member

oowl commented Aug 3, 2023

Can you help us to add these missing schema in the current PR?

suyanhanx
suyanhanx approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@oowl oowl merged commit 71dd3a5 into apache:main Aug 3, 2023
85 checks passed
@Ranxy Ranxy deleted the schema_from_str branch August 3, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@oowl oowl oowl approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ranxy @oowl @suyanhanx