Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(bindings/java): enable auto staging JARs on Apache Nexus repository #2939

Merged
merged 10 commits into from
Aug 27, 2023

Conversation

tisonkun
Copy link
Member

No description provided.

@tisonkun
Copy link
Member Author

Waiting for approval - https://issues.apache.org/jira/browse/INFRA-24928

We need this action to set up protoc on all platforms instead of manually tweaks.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

@Xuanwo we can proeprly staging the artifacts now!

But I noticed that the staged osx_aarch64 JAR contains x86_64's dylib. I'm digging into the details and will remove the debugging trick before calling a merge.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

@Xuanwo @suyanhanx This is ready for review now!

Comment on lines +21 to +26
push:
tags:
# Staging JARs on Apache Nexus repository for RCs. Read more on
# https://opendal.apache.org/docs/contributing/release#release-maven-artifacts
- 'v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+'
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few thoughts on these triggers:

  1. I keep the workflow_dispatch so that we can somehow debug the workflow. It's possible that we retain only this trigger and let the RM trigger release staging on a tag manually. But let's try to do it fully automatically now.
  2. For the tag triggers:

I create a pattern that only staging for each RC. This is because we only staging the artifacts instead of fire the release. The staging artifacts can be found at https://repository.apache.org/#stagingRepositories. For example, the last commit debugging commit staging orgapacheopendal-1012:

image

I'll click "Drop" to clean up. And a RM should "Drop" on vote failed; "Close" and later "Release" on vote passed.

Note that since we tag -rcN Git tags now, other bindings releases should filter out the trigger on RCs, or following the process here to staging on RCs.

.editorconfig Show resolved Hide resolved
.github/workflows/release_java.yml Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Let's go!

@Xuanwo Xuanwo merged commit 30b7854 into main Aug 27, 2023
23 checks passed
@Xuanwo Xuanwo deleted the auto-release-java branch August 27, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants