-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(bindings/java): enable auto staging JARs on Apache Nexus repository #2939
Conversation
Signed-off-by: tison <wander4096@gmail.com>
5cc0069
to
e603006
Compare
Waiting for approval - https://issues.apache.org/jira/browse/INFRA-24928 We need this action to set up |
Signed-off-by: tison <wander4096@gmail.com>
e603006
to
799cb6b
Compare
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@Xuanwo we can proeprly staging the artifacts now! But I noticed that the staged osx_aarch64 JAR contains x86_64's dylib. I'm digging into the details and will remove the debugging trick before calling a merge. |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@Xuanwo @suyanhanx This is ready for review now! |
push: | ||
tags: | ||
# Staging JARs on Apache Nexus repository for RCs. Read more on | ||
# https://opendal.apache.org/docs/contributing/release#release-maven-artifacts | ||
- 'v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+' | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few thoughts on these triggers:
- I keep the
workflow_dispatch
so that we can somehow debug the workflow. It's possible that we retain only this trigger and let the RM trigger release staging on a tag manually. But let's try to do it fully automatically now. - For the tag triggers:
I create a pattern that only staging for each RC. This is because we only staging the artifacts instead of fire the release. The staging artifacts can be found at https://repository.apache.org/#stagingRepositories. For example, the last commit debugging commit staging orgapacheopendal-1012
:
![image](https://private-user-images.githubusercontent.com/18818196/263506570-0c17e824-753a-4c9a-a23e-ea4c46ca456a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgwMjY4NzQsIm5iZiI6MTcxODAyNjU3NCwicGF0aCI6Ii8xODgxODE5Ni8yNjM1MDY1NzAtMGMxN2U4MjQtNzUzYS00YzlhLWEyM2UtZWE0YzQ2Y2E0NTZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEwVDEzMzYxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NDUyODRlMjZlNWQwOGE2NjMxOTY0NDZjZWI4Y2UwZTA3Nzg0YWU0ZDM3NGExNmE2ZmY5ZmYwYjk0OGNmYWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WrzhgKqbEI9dtcx77AAeDUScv_Am2F2gCyRnDlvqRHQ)
I'll click "Drop" to clean up. And a RM should "Drop" on vote failed; "Close" and later "Release" on vote passed.
Note that since we tag -rcN
Git tags now, other bindings releases should filter out the trigger on RCs, or following the process here to staging on RCs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Let's go!
No description provided.