Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs|java): Add place holder for BDD test #2962

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix(nodejs|java): Add place holder for BDD test #2962

merged 2 commits into from
Aug 29, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 29, 2023

Fix #2960

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from tisonkun as a code owner August 29, 2023 04:59
@Xuanwo Xuanwo changed the title fix(nodejs/tests): Add place holder for BDD test fix(nodejs|java): Add place holder for BDD test Aug 29, 2023
@suyanhanx suyanhanx changed the title fix(nodejs|java): Add place holder for BDD test fix(nodejs/java): Add place holder for BDD test Aug 29, 2023
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo changed the title fix(nodejs/java): Add place holder for BDD test fix(nodejsjava): Add place holder for BDD test Aug 29, 2023
@suyanhanx suyanhanx merged commit d4614fd into main Aug 29, 2023
30 checks passed
@suyanhanx suyanhanx deleted the fix-nodejs branch August 29, 2023 05:10
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

It's by design to use nodejs|java in PR title since java is not part of nodejs.

@Xuanwo Xuanwo changed the title fix(nodejsjava): Add place holder for BDD test fix(nodejs|java): Add place holder for BDD test Aug 29, 2023
@suyanhanx
Copy link
Member

It's by design to use nodejs|java in PR title since java is not part of nodejs.

I see.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

And this PR is merged too quickly: the test for java is not passed yet (which is the goal of this PR)

@suyanhanx
Copy link
Member

And this PR is merged too quickly: the test for java is not passed yet (which is the goal of this PR)

Yes. You're correct. I'll take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test for nodejs binding
3 participants