Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/cpp): expose all api returned by value #3001

Merged
merged 4 commits into from
Sep 2, 2023
Merged

Conversation

silver-ymz
Copy link
Member

Update:

  1. expose is_exist, create_dir, copy, rename, remove, stat, list.
    Now it only remains reader, writer, lister.
  2. add valgrind in test ci to check more memory leak occasion
  3. add docs-only option to avoid install dependency in docs ci

About Operator::read, I changed impl in #2984 because address sanitizer outputs container overflow. But I found that this is a misinformation caused by missing sanitize option for libopendal_cpp. As result, I revert previous impl. However, we still can't avoid copy because all std::vector pointer constructor use copy to hide internal structure.

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
bindings/cpp/src/lib.rs Outdated Show resolved Hide resolved
bindings/cpp/src/lib.rs Outdated Show resolved Hide resolved
bindings/cpp/src/lib.rs Outdated Show resolved Hide resolved
@silver-ymz
Copy link
Member Author

Since all conversations have answers, could anyone give an approval?

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 1dfc7e6 into main Sep 2, 2023
21 checks passed
@Xuanwo Xuanwo deleted the cpp-more-operation branch September 2, 2023 13:34
@silver-ymz silver-ymz mentioned this pull request Sep 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants