-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor oio::Write by accepting oio::Reader instead #3008
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this change is good, but the renaming is unacceptable. Although it changes the acceptable type of the content, it does not align with the general concept of a pipe, which involves data transmission/ communication as a pipe.It remains a sink,performing the final consumption action. This renaming makes the modification difficult to accept without a rfc or issue for discussion. |
|
No description provided.