Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Rename confusing pipe into copy_from #3015

Merged
merged 2 commits into from
Sep 6, 2023
Merged

refactor(core): Rename confusing pipe into copy_from #3015

merged 2 commits into from
Sep 6, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 6, 2023

Address #3008 (comment)

@Xuanwo
refactor(core): Rname confusing pipe into copy_from
5b9a986 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
rename api
6765b15 
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

#3008 (comment)

What do your mean? Is this bad? Widely use means acceptable for most people.

And copy_from is also a bit wired. It could represents anything, but writer only accepts a stream.
Why not keep sink, just short and sweet. And it actually means that it consumes a stream.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 6, 2023 •
edited

writer only accepts a stream.

It's a Reader, not a Stream. And Writer::copy_from a reader does make sense to me.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 6, 2023

Why not keep sink, just short and sweet. And it actually means that it consumes a stream.

I'm guessing you have missed something of our new Write API.

@suyanhanx suyanhanx changed the title refactor(core): Rname confusing pipe into copy_from refactor(core): Rename confusing pipe into copy_from Sep 6, 2023
@suyanhanx
Copy link
Member

I have confirmed your changes. Making modifications only on the raw API is acceptable.
Please update the description of the previous PR to explain the motivation and purpose. Thank you.

suyanhanx
suyanhanx approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 0ac6d29 into main Sep 6, 2023
92 checks passed
@Xuanwo Xuanwo deleted the rename_to_copy branch September 6, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xuanwo @suyanhanx