Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Polish multipart writer to allow oneshot optimization #3031

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 11, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This also requires test to cover

@Xuanwo Xuanwo merged commit bf85c1f into main Sep 11, 2023
92 checks passed
@Xuanwo Xuanwo deleted the refactor-buffer branch September 11, 2023 12:58
@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 11, 2023

LGTM. This also requires test to cover

How about starting an issue for this?

@suyanhanx
Copy link
Member

LGTM. This also requires test to cover

How about starting an issue for this?

#3033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants