Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/java): auto enable blocking layer #3049

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Sep 13, 2023

This closes #3037.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

After an offline discussion with @Xuanwo we agree that the Java binding can build its own layers when the Operator interface catches up.

Currently, the inevitable layer to enable in the Rust side is BlockingLayer that auto adapts async calls as blocking calls to support BlockingOperator.

Other layers, like RetryLayer, should be easily implemented in the Java side.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun changed the title feat(bindings/java): support configure layers feat(bindings/java): auto enable blocking layer Sep 13, 2023
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit eae0115 into apache:main Sep 13, 2023
22 of 25 checks passed
@tisonkun tisonkun deleted the java-layer-spec branch September 13, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java binding smoking test failed
2 participants