-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Move platform build checks from java binding to rust core #3060
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should verify build per PR which will be delivered in the release. Otherwise we should not release them or we "postpone" all the potential issues just before the release, which is not a good idea.
Service related staff should be covered by opendal rust core. So the real problem is we don't build opendal rust on all platforms. How about adding jobs to cover them instead so that we can aovid repeat those job at binding side?
I add this since I prefer to remove |
Make sense.
I don't think we should "keep consistency" among bindings; each binding can have its own test suite for coverage. If there is a better solution, we can migrate. But if we don't find a possible way yet, let's keep it as is. |
LGTM. |
Signed-off-by: Xuanwo <github@xuanwo.io>
The TODO for redis has been removed. And I'm working on to make sure opendal rust covered on all platform. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
cc @tisonkun, would you like to take a look again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM.
No description provided.