Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add OwO 1st #3086

Merged
merged 6 commits into from
Sep 15, 2023
Merged

docs: Add OwO 1st #3086

merged 6 commits into from
Sep 15, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 15, 2023 •
edited

owo, Owo, owO, OwO!

@Xuanwo
docs: Add OwO #1
1466d2e 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner September 15, 2023 07:36
silver-ymz
silver-ymz reviewed Sep 15, 2023
View reviewed changes
website/blog/2023-09-14-owo-1/index.md Outdated Show resolved Hide resolved
website/blog/2023-09-14-owo-1/index.md Outdated Show resolved Hide resolved
Xuanwo and others added 2 commits September 15, 2023 16:11
@Xuanwo @silver-ymz
Update website/blog/2023-09-14-owo-1/index.md
16b36de 
Co-authored-by: Mingzhuo Yin <yinmingzhuo@gmail.com>
@Xuanwo
Update cpp
6fcb205 
Signed-off-by: Xuanwo <github@xuanwo.io>
tisonkun
tisonkun reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you expected to post this blog before or after the release?

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 15, 2023

Are you expected to post this blog before or after the release?

I expect to post this blog before the release, it's part of our v0.40 release:

  • OwO post
  • Changelog
  • Upgrade Note

@Xuanwo @tisonkun
Apply suggestions from code review
7c945c6 
Co-authored-by: tison <wander4096@gmail.com>
@Xuanwo @tisonkun
Update website/blog/2023-09-14-owo-1/index.md
e6a091b 
Co-authored-by: tison <wander4096@gmail.com>
tisonkun
tisonkun reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set a link to the release note where we acknowledge contributors for making this release. This is why I may suggest you post this blog after the release; but we can always update blog later.

@Xuanwo Xuanwo merged commit e7a8990 into main Sep 15, 2023
2 checks passed
@Xuanwo Xuanwo deleted the owo-1 branch September 15, 2023 09:45
@chitralverma
Copy link

amazing! I was going to add a comment to make the metadata/ listing apis a little consistent and just stumbled on this.
looking forward to the latest release 0.4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@suyanhanx suyanhanx suyanhanx left review comments

@Young-Flash Young-Flash Young-Flash left review comments

@silver-ymz silver-ymz silver-ymz approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@sundy-li sundy-li Awaiting requested review from sundy-li

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Xuanwo @chitralverma @tisonkun @suyanhanx @Young-Flash @silver-ymz