Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(services/webhdfs): Rewrite webhdfs methods signature by using OpXxxx #3109

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

cxorm
Copy link
Member

@cxorm cxorm commented Sep 18, 2023

This PR addressed the webhdfs part of the issue: #3064

[Note]
I just ran the unit test by cargo test on my local environment.
Please correct me if I missed anything.

@cxorm
Copy link
Member Author

cxorm commented Sep 18, 2023

Rebase main branch to trigger CI.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks!

core/src/raw/ops.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 9b4b762 into apache:main Sep 18, 2023
30 checks passed
Young-Flash pushed a commit to Young-Flash/opendal that referenced this pull request Sep 19, 2023
…ing `OpXxxx` (apache#3109)

* refactor(service/webHDFS): Passing OpWrite instead of content_type

* refactor(service/webHDFS): Passing OpList instead of start_after

refactor(service/webHDFS): Passing OpList instead of start_after

* use existing API of raw::ops

* format the code snippets of modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants