Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(binding/java): add behavior test framework #3129

Merged
merged 26 commits into from
Sep 22, 2023
Merged

test(binding/java): add behavior test framework #3129

merged 26 commits into from
Sep 22, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Sep 19, 2023

Related: #3066

Xuanwo
Xuanwo reviewed Sep 19, 2023
View reviewed changes
.github/workflows/service_test_redis.yml Show resolved Hide resolved
bindings/java/.env.example Outdated Show resolved Hide resolved
bindings/java/README.md Outdated Show resolved Hide resolved
bindings/java/src/test/java/org/apache/opendal/services/S3Test.java Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Sep 21, 2023
View reviewed changes
bindings/java/README.md Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title test(binding/java): add behavior test framework for java feat(binding/java): add behavior test framework for java Sep 21, 2023
@G-XD
Copy link
Contributor Author

G-XD commented Sep 21, 2023

Hi, @Xuanwo PTAL

@tisonkun tisonkun mentioned this pull request Sep 21, 2023
Merged
tisonkun
tisonkun requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we move the redis test in the new framework first instead of making several different things in one PR. This causes a mess for merging.

tisonkun
tisonkun reviewed Sep 21, 2023
View reviewed changes
bindings/java/README.md Outdated Show resolved Hide resolved
@G-XD G-XD mentioned this pull request Sep 21, 2023
Merged
@G-XD
Merge branch 'main' into behavior_test_java
55a495a 
# Conflicts:
#	bindings/java/src/lib.rs
#	bindings/java/src/main/java/org/apache/opendal/Capability.java
#	bindings/java/src/main/java/org/apache/opendal/Operator.java
#	bindings/java/src/operator.rs
#	bindings/java/src/test/java/org/apache/opendal/AsyncStepsTest.java
#	bindings/java/src/test/java/org/apache/opendal/BlockingOperatorTest.java
#	bindings/java/src/test/java/org/apache/opendal/OperatorInfoTest.java
#	bindings/java/src/test/java/org/apache/opendal/OperatorTest.java
#	bindings/java/src/test/java/org/apache/opendal/RedisServiceTest.java
#	bindings/java/src/test/java/org/apache/opendal/StepsTest.java
@G-XD
test(binding/java): init all services test that OPENDAL_<SERVICE>_ON …
5d9bfd9 
…is true
@G-XD
ci(binding/java): del test
f3019b9
@G-XD
test(binding/java): skip test when no services turn on
f6d8395
@G-XD
doc(binding/java): update doc
658a675
Xuanwo
Xuanwo approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Invite @tisonkun to take another look.

@tisonkun tisonkun self-requested a review September 22, 2023 04:47
tisonkun
tisonkun approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 2160dd6 into apache:main Sep 22, 2023
42 checks passed
@tisonkun tisonkun changed the title feat(binding/java): add behavior test framework for java test(binding/java): add behavior test framework Sep 22, 2023
@G-XD
Copy link
Contributor Author

G-XD commented Sep 22, 2023

By the way, is it necessary to add tests for presigned related operations?

@suyanhanx suyanhanx mentioned this pull request Oct 8, 2023
Merged
@G-XD G-XD deleted the behavior_test_java branch October 13, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@tisonkun tisonkun tisonkun approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@G-XD @Xuanwo @tisonkun