build(bindings/java): support explicit cargo build target #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
|
No. musl doesn't support dynamic linking. So basically it requires a container env for building. |
Signed-off-by: tison <wander4096@gmail.com>
|
I work out a hack with suggestions at rust-lang/rust#44991. |
tisonkun
force-pushed
the
support-targets
branch
6 times, most recently
from
62b5992
to
895b35b
Compare
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
support-targets
branch
from
895b35b
to
f7767a2
Compare
Signed-off-by: tison <wander4096@gmail.com>
|
Still you need to have musl-gcc installed or proper GLIBC version installed. There is little things we can help in this perspective. But support explicit cargo build target helps users build with other toolchain so it's still valuable. |
tisonkun
commented
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3160.
With this patch, it's expected to fix the original issue with:
@G-XD please give it a try.