feat(prometheus): add bytes metrics as counter #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
force-pushed
the
add-metrics-about-bytes-counter
branch
from
66bf78e
to
4ef8b0b
Compare
Xuanwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the previous PR I converted the metrics in PrometheusLayer as it into PrometheusClientLayer, but I missed an important metric not included in the PrometheusLayer before is the bytes total metrics.
we already have a histogram about the bytes which is useful for us to find out the distribution of the size on different IO requests. however, a bytes metric in counter is more useful for us to get the IO bandwidth infomation, which is important for us to diagnose the issues on IO.
this PR also fixed a naming issue about counters in PrometheusClientLayer, the prometheus-client tend to append a
_totalsuffix in a dump way for every counters, if we name a counter asopendal_errors_totalwhat we finally get isopendal_errors_total_total, which is bad :(