Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service/d1): Support d1 for opendal #3248

Merged
merged 7 commits into from
Oct 13, 2023
Merged

feat(service/d1): Support d1 for opendal #3248

merged 7 commits into from
Oct 13, 2023

Conversation

realtaobo
Copy link
Contributor

for #3216

@Xuanwo
Copy link
Member

Xuanwo commented Oct 9, 2023

you can run the test via cargo test services_d1 --features services-d1

@realtaobo realtaobo force-pushed the dev/d1 branch 2 times, most recently from 3d0ed6b to efc9879 Compare October 12, 2023 09:25
@realtaobo
Copy link
Contributor Author

@Xuanwo I passed the local behavior, but d1 limited the Maximum string, BLOB or table row size to 1M, so before that I reduced gen_bytes locally.

@realtaobo realtaobo marked this pull request as ready for review October 12, 2023 09:33
Xuanwo
Xuanwo reviewed Oct 12, 2023
View reviewed changes
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/backend.rs Show resolved Hide resolved
core/src/services/d1/backend.rs Outdated Show resolved Hide resolved
core/src/services/d1/error.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Oct 13, 2023

Mostly LGTM! The only thing left here is to make clippy happy. Please make sure you have rust updated to latest via rustup update.

Xuanwo
Xuanwo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit eb4b136 into apache:main Oct 13, 2023
111 checks passed
@realtaobo realtaobo deleted the dev/d1 branch October 13, 2023 08:53
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realtaobo @Xuanwo