Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/sqlite): Polish sqlite via adding connection pool #3249

Merged
merged 1 commit into from
Oct 9, 2023
Merged

refactor(services/sqlite): Polish sqlite via adding connection pool #3249

merged 1 commit into from
Oct 9, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 9, 2023

No description provided.

@Xuanwo Xuanwo requested review from suyanhanx and G-XD October 9, 2023 15:27
tisonkun
tisonkun reviewed Oct 9, 2023
View reviewed changes
bindings/java/Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo
polish
a76e635 
Signed-off-by: Xuanwo <github@xuanwo.io>
PsiACE
PsiACE approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm wondering if it would be more appropriate to introduce an ORM for MySQL, SQLite, and PostgreSQL instead of implementing them separately. At least we can maintain less code.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 9, 2023

I'm wondering if it would be more appropriate to introduce an ORM for MySQL, SQLite, and PostgreSQL instead of implementing them separately.

I hate ORM.

@Xuanwo Xuanwo merged commit 593a789 into main Oct 9, 2023
103 checks passed
@Xuanwo Xuanwo deleted the polish-sqlite branch October 9, 2023 16:21
Zheaoli pushed a commit to Zheaoli/opendal that referenced this pull request Oct 12, 2023
@Xuanwo @Zheaoli
refactor(services/sqlite): Polish sqlite via adding connection pool (a…
fc1e281 
…pache#3249)
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@PsiACE PsiACE PsiACE approved these changes

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

@G-XD G-XD Awaiting requested review from G-XD

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xuanwo @tisonkun @PsiACE