feat(binding/python): allow setting append/buffer/more in write() call #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokester
force-pushed
the
python-binding-expose-more
branch
from
f1cc133
to
17f4ce5
Compare
Xuanwo
reviewed
Oct 10, 2023
jokester
commented
Oct 10, 2023
Xuanwo
reviewed
Oct 11, 2023
Xuanwo
reviewed
Oct 11, 2023
Xuanwo
reviewed
Oct 11, 2023
Xuanwo
reviewed
Oct 11, 2023
|
This PR mostly LGTM. Needs @messense to confirm the pyi changes. |
Zheaoli
pushed a commit
to Zheaoli/opendal
that referenced
this pull request
Oct 12, 2023
apache#3256) * binding/python: add new parameters to stub methods * add parameters to implementations * run cargo fmt * make clippy happy * run black on py stubs * Operator: read and apply kwargs in PyDict * refactor kwargs recognition to struct WriteOptions * touch test to see if WriteOptions worked * Revert "touch test to see if WriteOptions worked" This reverts commit bb38127. * remove WriteOptions and reuse od::OpWrite * rewrite build_opwrite()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3242
This PR adds named parameters to python
Operator.write()AsyncOperator.write()methods, to allow append/buffer/content_type/more to be set.