Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Introduce OpenDAL Workflow Planner #3258

Merged
merged 37 commits into from
Oct 13, 2023
Merged

refactor: Introduce OpenDAL Workflow Planner #3258

merged 37 commits into from
Oct 13, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 11, 2023

This PR aims to introduce the OpenDAL workflow planner, allowing us to reuse our test setup across different components.

image

Future works:

Build artifacts only once

How to implement the build/upload/download/test logic for java? cc @tisonkun @G-XD

Normalize the usage of service scheme

Is it possible for java & python to accept scheme in their command?

Currently:

  • java uses maven -Dtest=org.apache.opendal.test.behavior.RedisTest
  • python users pytest -vk TestMemory

Is it possible to make them accept s3/memory in command directly so that we can concat them like cargo nextest run services_${{ inputs.service }}?

cc @tisonkun @G-XD @laipz8200

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review October 12, 2023 17:34
@Xuanwo Xuanwo requested a review from PsiACE as a code owner October 12, 2023 17:34
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!LGTM.

@tisonkun
Copy link
Member

tisonkun commented Oct 12, 2023

How to implement the build/upload/download/test logic for java

Something like this - korandoru/hawkeye@386d815

@tisonkun
Copy link
Member

make them accept s3/memory in command directly

Of course with JUnit's @Tag.

@laipz8200
Copy link
Contributor

Is it possible to make them accept s3/memory in command directly so that we can concat them like cargo nextest run services_${{ inputs.service }}?

pytest has custom mark like pytest.mark.s3. By the way, -k is also worked for this scene, pytest -vk memory will select TestMemory too.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 13, 2023

By the way, -k is also worked for this scene, pytest -vk memory will select TestMemory too.

Can we use abc-def with TestAbcDef?

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@laipz8200
Copy link
Contributor

By the way, -k is also worked for this scene, pytest -vk memory will select TestMemory too.

Can we use abc-def with TestAbcDef?

Unfortunately, it cannot. pytest matches test cases by class name, function name, or custom mark (case-insensitive).

To match with abc_def, we can rename our class name or give a custom mark on it, but I think it cannot contain -. (_ is ok)

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 13, 2023

To match with abc_def, we can rename our class name or give a custom mark on it, but I think it cannot contain -. (_ is ok)

Okay, let's handle snake case conversion on the actions side instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants