Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/java): align mapping POJO pattern #3289

Merged
merged 1 commit into from
Oct 15, 2023
Merged

chore(bindings/java): align mapping POJO pattern #3289

merged 1 commit into from
Oct 15, 2023

Conversation

tisonkun
Copy link
Member

Per #3277 (comment)

Align the POJO style -

  1. Generate getters for public final field to satisfy where only methods are accepted.
  2. Always overwrite the RequiredArgsConstructor for ensure the parameter order.

cc @Xuanwo @G-XD

@tisonkun
style(bindings/java): align mapping POJO pattern
f492827 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested review from Xuanwo and G-XD October 15, 2023 15:59
@Xuanwo Xuanwo changed the title style(bindings/java): align mapping POJO pattern chore(bindings/java): align mapping POJO pattern Oct 15, 2023
Xuanwo
Xuanwo approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tisonkun tisonkun merged commit 945ff82 into apache:main Oct 15, 2023
50 checks passed
@tisonkun tisonkun deleted the refactor-java branch October 15, 2023 16:41
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@G-XD G-XD Awaiting requested review from G-XD

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tisonkun @Xuanwo