Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service/azfile): add azure file service support #3312

Merged
merged 7 commits into from
Oct 17, 2023
Merged

feat(service/azfile): add azure file service support #3312

merged 7 commits into from
Oct 17, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Oct 17, 2023 •
edited

part of: #3047

@dqhl76
feat: add azure file service support
31ab742 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76
feat: add azure file list operation
a29a458 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76
fix: parent path should exist
fe676d4 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 marked this pull request as draft October 17, 2023 02:17
@dqhl76 dqhl76 marked this pull request as ready for review October 17, 2023 02:29
Xuanwo
Xuanwo reviewed Oct 17, 2023
View reviewed changes
core/src/services/azfile/backend.rs Outdated Show resolved Hide resolved
core/src/services/azfile/backend.rs Show resolved Hide resolved
core/src/services/azfile/backend.rs Outdated Show resolved Hide resolved
core/src/services/azfile/backend.rs Show resolved Hide resolved
core/src/services/azfile/backend.rs Outdated Show resolved Hide resolved
core/src/services/azfile/backend.rs Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's go!

@Xuanwo Xuanwo merged commit 8c6e7db into apache:main Oct 17, 2023
112 checks passed
@dqhl76
Copy link
Member Author

dqhl76 commented Oct 17, 2023 •
edited

I have a Azure File serivce account and will add integration test for next PR.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 17, 2023

I have a Azure File serivce account and will add integration test for next PR.

You can add the account to 1Password and share it with me. I will then copy it to our services vault.

@dqhl76 dqhl76 mentioned this pull request Oct 28, 2023
Merged
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
@dqhl76 dqhl76 deleted the azure-file-service branch December 25, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dqhl76 @Xuanwo