refactor(tests): Apply OPENDAL_TEST for behavior test #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
86 tasks
suyanhanx
reviewed
Oct 17, 2023
suyanhanx
reviewed
Oct 17, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
cc @suyanhanx, would you like to take another review? |
|
|
tisonkun
reviewed
Oct 17, 2023
| env: | ||
| OPENDAL_S3_TEST: on | ||
| OPENDAL_TEST: s3 |
There was a problem hiding this comment.
@Xuanwo It seems we should align Java's behavior test with this option change?
If so, may you create an issue and ping me >_<
There was a problem hiding this comment.
Maybe python also needs to align?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, inspired by @eryue0220's PR (#3297), simplifies test behavior control through an environment variable rather than arguments. This improvement eliminates the need for code repetition across all services.
OPENDAL_XXX_TESTanymore.