Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/java): Migrate behavior tests to new Workflow Planner #3341

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 18, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@tisonkun
Copy link
Member

It seems Java S3 service test is not run after this change?

@tisonkun
Copy link
Member

image

Only redis test run.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 18, 2023

It seems Java S3 service test is not run after this change?

Excluded by our planner. Let's add a new rule.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 18, 2023

cc @tisonkun, would you like to take another look?

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't check the py files closely. The result seems good. Let's give it a try.

@Xuanwo Xuanwo merged commit e80e32c into main Oct 18, 2023
22 checks passed
@Xuanwo Xuanwo deleted the add-java-test-support branch October 18, 2023 13:14
@tisonkun
Copy link
Member

FWIW - we can later polish the CI job name, it's a bit LTA (less than awesome if I bikeshedding a bit XD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants