Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update object_store unit tests and s3 endpoint docs #3345

Merged
merged 3 commits into from
Oct 18, 2023
Merged

chore: update object_store unit tests and s3 endpoint docs #3345

merged 3 commits into from
Oct 18, 2023

Conversation

thorseraq
Copy link
Contributor

This PR contains two small updates, hope can help a little bit:

  • add actual bytes comparing at object_store
  • add Cloudflare R2 endpoint, ref

Xuanwo
Xuanwo approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit c52061a into apache:main Oct 18, 2023
43 checks passed
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thorseraq @Xuanwo