Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service/cloudflare_kv): support cloudflare KV #3348

Merged
merged 8 commits into from
Oct 23, 2023
Merged

feat(service/cloudflare_kv): support cloudflare KV #3348

merged 8 commits into from
Oct 23, 2023

Conversation

my-vegetable-has-exploded
Copy link
Contributor

close #3217

Implement cloudflare kv support via our KV adaptor.

@my-vegetable-has-exploded my-vegetable-has-exploded mentioned this pull request Oct 19, 2023
Closed
@Xuanwo Xuanwo changed the title feat(service/Cloudflare kv):support cloudflare KV feat(service/cloudflare_kv):support cloudflare KV Oct 19, 2023
@Xuanwo Xuanwo changed the title feat(service/cloudflare_kv):support cloudflare KV feat(service/cloudflare_kv): support cloudflare KV Oct 19, 2023
Xuanwo
Xuanwo reviewed Oct 19, 2023
View reviewed changes
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Show resolved Hide resolved
@my-vegetable-has-exploded
feat(service/Cloudflare kv):support cloudflare KV
6ea0bc6 
init cloudflare-kv

implement builder.

Implement read

implement scan

feat(service/Cloudflare kv):support cloudflare KV
@my-vegetable-has-exploded
fix: fmt
ce42c98
@my-vegetable-has-exploded
fix ..
a031aaf
@my-vegetable-has-exploded
fix clippy
7f6e89b
Xuanwo
Xuanwo reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! The only thing left is make sure our files have correct licenses.

Xuanwo
Xuanwo reviewed Oct 23, 2023
View reviewed changes
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
core/src/services/cloudflare_kv/backend.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 429972b into apache:main Oct 23, 2023
109 of 112 checks passed
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cloudflare KV support
2 participants
@my-vegetable-has-exploded @Xuanwo