Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(service/postgresql): Migrate task to new task planner #3358

Merged
merged 3 commits into from
Oct 23, 2023
Merged

refactor(service/postgresql): Migrate task to new task planner #3358

merged 3 commits into from
Oct 23, 2023

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Oct 23, 2023

Signed-off-by: Manjusaka me@manjusaka.me

Xuanwo
Xuanwo reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have behavior test for pg before?

@Zheaoli
Copy link
Member Author

Zheaoli commented Oct 23, 2023

We don't have behavior test for pg before?

No we have, I missed some diff

Update pr later.

@Zheaoli
refactor(service/postgresql): Migrate task to new task planner
96c0dd3 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Update code
ee49226 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
update code
272298c 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/migrate-postgresql-task branch from 9eb8fa5 to 272298c Compare October 23, 2023 05:09
@Zheaoli Zheaoli requested a review from Xuanwo October 23, 2023 05:09
Xuanwo
Xuanwo approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 73eea44 into apache:main Oct 23, 2023
5 checks passed
@Zheaoli Zheaoli deleted the manjusaka/migrate-postgresql-task branch October 23, 2023 06:03
@suyanhanx suyanhanx mentioned this pull request Oct 24, 2023
Closed
86 tasks
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zheaoli @Xuanwo