Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(service/dropbox): migrate to test planner #3381

Merged
merged 1 commit into from
Oct 30, 2023
Merged

refactor(service/dropbox): migrate to test planner #3381

merged 1 commit into from
Oct 30, 2023

Conversation

suyanhanx
Copy link
Member

No description provided.

@suyanhanx
Copy link
Member Author

suyanhanx commented Oct 25, 2023 •
edited

It looks like a java binding issue may have been found. This is a path related error. cc @Xuanwo @tisonkun @G-XD
https://github.com/apache/incubator-opendal/actions/runs/6643127435/job/18049511860?pr=3381

FYI:

@tisonkun
Copy link
Member

tisonkun commented Oct 25, 2023 •
edited

Interesting. This seems a dropbox limitation where we can skip the test case for this special service.

That is, Dropbox seems not support unicode emoji in path.

@suyanhanx
Copy link
Member Author

suyanhanx commented Oct 25, 2023 •
edited

Interesting. This seems a dropbox limitation where we can skip the test case for this special service.

That is, Dropbox seems not support unicode emoji in path.

I'll add a test to core and give it a try.
The case has been removed.

@suyanhanx suyanhanx mentioned this pull request Oct 30, 2023
Closed
86 tasks
@suyanhanx
refactor(service/dropbox): migrate to test planner
fde5056 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review October 30, 2023 14:59
Xuanwo
Xuanwo approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d60befd into main Oct 30, 2023
5 checks passed
@Xuanwo Xuanwo deleted the dropbox-test-planner branch October 30, 2023 15:14
@Xuanwo
Copy link
Member

Xuanwo commented Oct 30, 2023

License check failed

[main] INFO io.korandoru.hawkeye.command.HawkEyeCommandCheck - Found missing header files: [/github/workspace/.github/workflows/service_test_dropbox.yml]

@suyanhanx
Copy link
Member Author

License check failed

[main] INFO io.korandoru.hawkeye.command.HawkEyeCommandCheck - Found missing header files: [/github/workspace/.github/workflows/service_test_dropbox.yml]

Let me take a look

@Xuanwo
Copy link
Member

Xuanwo commented Oct 30, 2023

Let me take a look

Thanks in advance!

@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suyanhanx @tisonkun @Xuanwo