Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/cos): fix prefix param #3384

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(services/cos): fix prefix param #3384

merged 1 commit into from
Oct 25, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Oct 25, 2023

Fix: #3383

@G-XD G-XD requested a review from Xuanwo as a code owner October 25, 2023 17:54
@Xuanwo
Copy link
Member

Xuanwo commented Oct 25, 2023

Hi, since you are a committer now, you can submit PR from apache upstream directly which allows our CI to run.

PR from forked repo can't run CI that needs secrets.

Xuanwo
Xuanwo approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 813a29e into apache:main Oct 25, 2023
60 checks passed
@G-XD G-XD deleted the fix_cos_list branch October 25, 2023 18:14
@Xuanwo Xuanwo mentioned this pull request Oct 27, 2023
Closed
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java service test failed
2 participants
@G-XD @Xuanwo