Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Enable new test workflow planner for python binding #3397

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Oct 26, 2023

For now, We already have the behavior test for Java for each service.

I think it would be better to support for python

In this PR, I do following things

  1. Support for python binding test
  2. Add hint for plan.py

@Zheaoli Zheaoli marked this pull request as draft October 26, 2023 15:21
@Zheaoli Zheaoli force-pushed the manjusaka/support-python-test branch from ed92ee1 to 2175d4f Compare October 26, 2023 15:46
@Zheaoli Zheaoli marked this pull request as ready for review October 26, 2023 15:46
@Zheaoli Zheaoli force-pushed the manjusaka/support-python-test branch from 2175d4f to 52c523a Compare October 26, 2023 15:46
.github/workflows/behavior_test.yml Outdated Show resolved Hide resolved
.github/workflows/behavior_test_binding_python.yml Outdated Show resolved Hide resolved
.github/actions/behavior_test_binding_python/action.yaml Outdated Show resolved Hide resolved
bindings/python/tests/test_services.py Outdated Show resolved Hide resolved
bindings/python/tests/test_services.py Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title feat(test): Support behavior test for Python for core service feat(test): Enable new test workflow planner for python binding Oct 26, 2023
@Zheaoli Zheaoli marked this pull request as draft October 26, 2023 15:59
@Zheaoli Zheaoli force-pushed the manjusaka/support-python-test branch 2 times, most recently from 837c3da to 4058345 Compare October 30, 2023 12:07
@Zheaoli Zheaoli marked this pull request as ready for review October 30, 2023 12:07
@Zheaoli
Copy link
Member Author

Zheaoli commented Oct 30, 2023

In the newest commit, I do more thing after #3398 has been supported

  1. Refactor the class-based test to the function based test to help it easier to impl condition run
  2. Split different kinds of tests into different files to improve the maintainability

Now the PR ready for review

tests/test_capability.py::test_capability PASSED                                                                                                                                                                                                                      [  6%]
tests/test_capability.py::test_capability_exception PASSED                                                                                                                                                                                                            [ 12%]
tests/test_read.py::test_sync_read SKIPPED (skip because ('read', 'write', 'delete') not supported)                                                                                                                                                                   [ 18%]
tests/test_read.py::test_async_read SKIPPED (skip because ('read', 'write', 'delete') not supported)                                                                                                                                                                  [ 25%]
tests/test_read.py::test_sync_read_stat SKIPPED (skip because ('read', 'write', 'delete', 'stat') not supported)                                                                                                                                                      [ 31%]
tests/test_read.py::test_async_read_stat SKIPPED (skip because ('read', 'write', 'delete', 'stat') not supported)                                                                                                                                                     [ 37%]
tests/test_read.py::test_sync_read_not_exists PASSED                                                                                                                                                                                                                  [ 43%]
tests/test_read.py::test_async_read_not_exists PASSED                                                                                                                                                                                                                 [ 50%]
tests/test_write.py::test_sync_write SKIPPED (skip because ('write', 'delete', 'stat') not supported)                                                                                                                                                                 [ 56%]
tests/test_write.py::test_async_write SKIPPED (skip because ('write', 'delete', 'stat') not supported)                                                                                                                                                                [ 62%]
tests/test_write.py::test_sync_write_with_non_ascii_name SKIPPED (skip because ('write', 'delete', 'stat') not supported)                                                                                                                                             [ 68%]
tests/test_write.py::test_async_write_with_non_ascii_name SKIPPED (skip because ('write', 'delete', 'stat') not supported)                                                                                                                                            [ 75%]
tests/test_write.py::test_sync_create_dir SKIPPED (skip because ('create_dir', 'stat') not supported)                                                                                                                                                                 [ 81%]
tests/test_write.py::test_async_create_dir SKIPPED (skip because ('create_dir', 'stat') not supported)                                                                                                                                                                [ 87%]
tests/test_write.py::test_sync_delete SKIPPED (skip because ('delete', 'stat') not supported)                                                                                                                                                                         [ 93%]
tests/test_write.py::test_async_delete SKIPPED (skip because ('delete', 'stat') not supported)   

cc @Xuanwo @messense

@Zheaoli Zheaoli requested a review from Xuanwo October 30, 2023 12:14
@suyanhanx

This comment was marked as resolved.

Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/support-python-test branch from a67daec to 1fa99f4 Compare October 30, 2023 15:32
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's rock!

@Xuanwo Xuanwo merged commit c0e9640 into apache:main Oct 30, 2023
85 checks passed
@Zheaoli Zheaoli deleted the manjusaka/support-python-test branch October 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants