Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(binding/python): Export full_capability API for Python binding #3402

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat(binding/python): Export full_capability API for Python binding #3402

merged 2 commits into from
Oct 30, 2023

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Oct 27, 2023

Signed-off-by: Manjusaka me@manjusaka.me

@Zheaoli Zheaoli requested a review from PsiACE as a code owner October 30, 2023 07:50
@Zheaoli Zheaoli force-pushed the manjusaka/full_capability-python branch from 1375d94 to 9c19c39 Compare October 30, 2023 07:51
Xuanwo
Xuanwo reviewed Oct 30, 2023
View reviewed changes
bindings/python/Cargo.toml Outdated Show resolved Hide resolved
bindings/python/python/opendal/__init__.pyi Outdated Show resolved Hide resolved
bindings/python/src/capability.rs Outdated Show resolved Hide resolved
bindings/python/src/capability.rs Outdated Show resolved Hide resolved
core/src/types/capability.rs Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/full_capability-python branch from 9c641fa to ad3dfd6 Compare October 30, 2023 08:24
@Zheaoli
Copy link
Member Author

Zheaoli commented Oct 30, 2023

@messense @Xuanwo

For now, I chose to copy and paste the Capability impl to binding/Python to simplify the code by using the pyclass and get_all

About the test, I think we don't need add extra test to ensure that Capability in python is in sync with Capability in Rust. Here's the detail

  1. Capability API is stable, it would not be changed in couple of months or years.
  2. After refactor(services/libsql): Migrate libsql task to new behavior test planner #3363, each service would have there own behavior test for Python binding, if there's any change about Capability which got some side effect to the code, the test would fail.

Xuanwo
Xuanwo approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, please @messense take another look.

messense
messense approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Member

Xuanwo commented Oct 30, 2023

Thanks @Zheaoli for the hard work! And thanks @messense for the review. Merging...

@Xuanwo Xuanwo merged commit 6b57b42 into apache:main Oct 30, 2023
118 checks passed
@messense messense linked an issue Oct 30, 2023 that may be closed by this pull request
feat: Export capability api for Python binding #3398
Closed
@Zheaoli Zheaoli deleted the manjusaka/full_capability-python branch October 30, 2023 11:15
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Export capability api for Python binding
3 participants
@Zheaoli @Xuanwo @messense