Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/supabase): migrate to test planner #3406

Merged
merged 2 commits into from
Oct 30, 2023
Merged

refactor(services/supabase): migrate to test planner #3406

merged 2 commits into from
Oct 30, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Oct 27, 2023

No description provided.

@G-XD
Copy link
Contributor Author

G-XD commented Oct 27, 2023

Hi @Xuanwo , Should the testWriteFileWithNonAsciiName test be removed? This test was added separately due to #3195 and it is not synchronized with the rust behavior test.

This was referenced Oct 30, 2023
Closed
Closed
@Xuanwo
Copy link
Member

Xuanwo commented Oct 30, 2023

Should the testWriteFileWithNonAsciiName test be removed?

Yes, I think we should remove this test first until we know how to play with non ascii on different services.

@G-XD G-XD mentioned this pull request Oct 30, 2023
Merged
@G-XD
Merge branch 'main' into supabase_test_planner
5d2077c 
# Conflicts:
#	.github/workflows/service_test_supabase.yml
Xuanwo
Xuanwo approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 3362b13 into main Oct 30, 2023
5 checks passed
@Xuanwo Xuanwo deleted the supabase_test_planner branch October 30, 2023 15:38
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G-XD @Xuanwo