Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(services/azfile): add azfile integration test #3409

Merged
merged 7 commits into from
Oct 29, 2023
Merged

ci(services/azfile): add azfile integration test #3409

merged 7 commits into from
Oct 29, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Oct 28, 2023

close: #3047
related: #3312

  • Add integration test for Azure file share service
  • Fix rename operation related problems
  • Add comments that discussed last PR

Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 changed the title [WIP]ci(services/azfile): add azfile integration test ci(services/azfile): add azfile integration test Oct 28, 2023
@dqhl76 dqhl76 requested a review from tisonkun as a code owner October 28, 2023 12:36
@dqhl76
Copy link
Member Author

dqhl76 commented Oct 28, 2023

Hi, @Xuanwo. I am not sure if it is a behavior we expected. I find a lot of empty random directory. It seems related to the random root path setting. Do we need to delete them?
image

@tisonkun
Copy link
Member

Hi, @Xuanwo. I am not sure if it is a behavior we expected. I find a lot of empty random directory. It seems related to the random root path setting. Do we need to delete them?
image

What file path you find these files?

@dqhl76
Copy link
Member Author

dqhl76 commented Oct 29, 2023

What file path you find these files?

Thanks for your reply. It is not related to random root setting. I have located the problem:

the empty directories are under the root. I found out that this was because some of our behavior tests not clean up the tested directory. For example, test_list_dir_with_metakey_complete just delete path but forget to delete parent. It is out of this PR's scope. I think this PR is ready to be reviewed.
https://github.com/apache/incubator-opendal/blob/3c4a18776892edb331acb3eddbd74fc926a93cd7/core/tests/behavior/list.rs#L141-L142
https://github.com/apache/incubator-opendal/blob/3c4a18776892edb331acb3eddbd74fc926a93cd7/core/tests/behavior/list.rs#L174

@dqhl76 dqhl76 requested a review from Xuanwo October 29, 2023 04:01
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

bindings/java/Cargo.toml Show resolved Hide resolved
@Xuanwo Xuanwo merged commit b2b615b into main Oct 29, 2023
131 checks passed
@Xuanwo Xuanwo deleted the azfile-test branch October 29, 2023 06:10
@dqhl76
Copy link
Member Author

dqhl76 commented Oct 29, 2023

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Service: Add azure file service support
3 participants