Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(binding/java): fix return value of presign-related method #3433

Merged
merged 4 commits into from
Oct 31, 2023
Merged

fix(binding/java): fix return value of presign-related method #3433

merged 4 commits into from
Oct 31, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Oct 31, 2023

Fix error and add behavior test for presign.

@G-XD G-XD requested a review from tisonkun as a code owner October 31, 2023 12:13
tisonkun
tisonkun reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only one comment inline.

@G-XD G-XD marked this pull request as draft October 31, 2023 14:30
@G-XD G-XD marked this pull request as ready for review October 31, 2023 16:50
Xuanwo
Xuanwo approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 8df75c5 into main Oct 31, 2023
59 checks passed
@Xuanwo Xuanwo deleted the fix_binding_java branch October 31, 2023 16:51
@G-XD G-XD mentioned this pull request Oct 31, 2023
Closed
7 tasks
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@G-XD @Xuanwo @tisonkun