Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add opendal_metadata_last_modified and opendal_operator_create_dir #3515

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feat: Add opendal_metadata_last_modified and opendal_operator_create_dir #3515

merged 3 commits into from
Nov 7, 2023

Conversation

jiaoew1991
Copy link
Contributor

No description provided.

xyjixyjixyji
xyjixyjixyji reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other part so far LGTM, thanks

bindings/c/src/metadata.rs Outdated Show resolved Hide resolved
bindings/c/tests/bdd.cpp Outdated Show resolved Hide resolved
@jiaoew1991
Copy link
Contributor Author

By the way, there are more and more files under binding C. How about adding a CMakeLists.txt to manage them? Additionally, it will be easier to reference in other projects by FetchContent once we have the CMakeLists.txt.

@xyjixyjixyji
Copy link
Contributor

xyjixyjixyji commented Nov 7, 2023 •
edited

By the way, there are more and more files under binding C. How about adding a CMakeLists.txt to manage them? Additionally, it will be easier to reference in other projects by FetchContent once we have the CMakeLists.txt.

That's a great idea, Makefile is a little bit old school. Are you interested in doing this? I raised an issue for this #3516

@xyjixyjixyji xyjixyjixyji mentioned this pull request Nov 7, 2023
Open
xyjixyjixyji
xyjixyjixyji approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xyjixyjixyji xyjixyjixyji merged commit 64b61c7 into apache:main Nov 7, 2023
33 checks passed
@Xuanwo Xuanwo changed the title Add opendal_metadata_last_modified and opendal_operator_create_dir feat: Add opendal_metadata_last_modified and opendal_operator_create_dir Nov 8, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Nov 8, 2023

Hi, @Ji-Xinyou, It's required that all PR should contain semantic prefix like feat, fix so that we can generate correctly changelog: https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md#title

Please take it a look while merging PRs.

@xyjixyjixyji
Copy link
Contributor

Hi, @Ji-Xinyou, It's required that all PR should contain semantic prefix like feat, fix so that we can generate correctly changelog: https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md#title

Please take it a look while merging PRs.

Sorry for the mistake. Thanks for reminding me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyjixyjixyji xyjixyjixyji xyjixyjixyji approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiaoew1991 @xyjixyjixyji @Xuanwo