Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bindings/java): add basic usage in README #3534

Merged
merged 6 commits into from
Nov 12, 2023
Merged

docs(bindings/java): add basic usage in README #3534

merged 6 commits into from
Nov 12, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Nov 8, 2023

close #3522

test success

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect if we should add such an example. But if it's well-written, that can be fine.

bindings/java/README.md Outdated Show resolved Hide resolved
@caicancai
Copy link
Member Author

Do you want me to put this example in java test as a basic test

@tisonkun
Copy link
Member

tisonkun commented Nov 9, 2023

Do you want me to put this example in java test as a basic test

No. Our tests have coverage already.

Such an example can either serve in:

@caicancai
Copy link
Member Author

Do you want me to put this example in java test as a basic test

No. Our tests have coverage already.

Such an example can either serve in:

Thank you for your reply, on https://github.com/apache/incubator-opendal/tree/main/examples, it seems, are still need some other documents, is needed in my pr supplement or the next pr

@caicancai
Copy link
Member Author

@tisonkun hi, could you please help review this pr if you have time? At present, I plan to simply add an example in the readme

bindings/java/README.md Outdated Show resolved Hide resolved
@tisonkun tisonkun changed the title docs: Binding Java should add a basic usage in binding's README docs(bindings/java): add basic usage in README Nov 12, 2023
@tisonkun tisonkun merged commit faa574f into apache:main Nov 12, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Binding Java should add a basic usage in binding's README
2 participants