Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement RFC-3526: List Recursive #3556

Merged
merged 4 commits into from
Nov 10, 2023
Merged

feat: Implement RFC-3526: List Recursive #3556

merged 4 commits into from
Nov 10, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 10, 2023

This PR implements RFC-3526: List Recursive

In the future, we should eliminate list_without_recursive by ensuring every service supports listing the current directory. However, as this is a significant change that could affect many services, I suggest addressing it in a separate PR.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far LGTM, a very good API change to me

@Xuanwo Xuanwo merged commit fd3148a into main Nov 10, 2023
213 checks passed
@Xuanwo Xuanwo deleted the list-recursive branch November 10, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants