Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed dotenv in bindings/nodejs/index.js #3579

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: removed dotenv in bindings/nodejs/index.js #3579

merged 1 commit into from
Nov 13, 2023

Conversation

AlexVCS
Copy link
Contributor

@AlexVCS AlexVCS commented Nov 13, 2023

working to resolve #3576

@Xuanwo Xuanwo changed the title removed dotenv in bindings/nodejs/index.js chore: removed dotenv in bindings/nodejs/index.js Nov 13, 2023
Xuanwo
Xuanwo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 013c564 into apache:main Nov 13, 2023
59 checks passed
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binding/nodejs: dotenv should not be used in production code
2 participants
@AlexVCS @Xuanwo