Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add cpp binding Google style clang-format && format the code #3581

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

JackDrogon
Copy link
Contributor

Add cpp binding Google style clang-format && format the code

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleae also update CMake for code format job

bindings/cpp/.clang-format Show resolved Hide resolved
@Xuanwo Xuanwo changed the title Add cpp binding Google style clang-format && format the code chore: Add cpp binding Google style clang-format && format the code Nov 14, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Nov 14, 2023

Hi, @silver-ymz, would you like to take a review?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like git pre-commit. It's ok for me to merge this PR as is if @silver-ymz is ok with the Google Code Style.

Copy link
Member

@silver-ymz silver-ymz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 6d46e38 into apache:main Nov 14, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants