Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Change List API into poll based and return one entry instead #3593

Merged
merged 18 commits into from
Nov 16, 2023
Merged

refactor: Change List API into poll based and return one entry instead #3593

merged 18 commits into from
Nov 16, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 15, 2023

Close #3236

This introduce the following changes:

  • Change list api into poll based.
  • Return one entry instead of a page.
  • Introduce PageList for better performance.

@Xuanwo
Save work
c612316 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Save work
0849e07 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Save work
cae1763 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
save work
e00e06c 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Cargo check
f87b2e6 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Make clippy happy
4516c9d 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix test
ed3d112 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
polish errored
4f7f756 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix blocking
2729c78 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Polish flat lister
6ab30ca 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Polish naming
3d4a62b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Update upgrade
7155cae 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix header
aa70105 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge remote-tracking branch 'refs/remotes/origin/polish-lister' into…
08383bc 
… polish-lister
@Xuanwo Xuanwo mentioned this pull request Nov 15, 2023
Closed
4 tasks
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 15, 2023

dropbox test failed for it's rate limit, let's ignore it for now.

@Xuanwo
Use RUST_TEST_THREADS=1 instead
fe0f3b0 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner November 15, 2023 16:06
@Xuanwo
Fix gdrive
e0b3929 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix empty response
69483c7 
Signed-off-by: Xuanwo <github@xuanwo.io>
@xyjixyjixyji xyjixyjixyji mentioned this pull request Nov 15, 2023
Open
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 16, 2023

Hi, @suyanhanx & @ClSlaid, would you like to take a review?

@Xuanwo Xuanwo mentioned this pull request Nov 16, 2023
Merged
PsiACE
PsiACE approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

@Xuanwo Xuanwo mentioned this pull request Nov 16, 2023
Closed
@Xuanwo Xuanwo merged commit 179b4a1 into main Nov 16, 2023
214 checks passed
@Xuanwo Xuanwo deleted the polish-lister branch November 16, 2023 09:45
@suyanhanx suyanhanx mentioned this pull request Nov 16, 2023
Merged
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@PsiACE PsiACE PsiACE approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issues of RFC-3232: Align List API
4 participants
@Xuanwo @suyanhanx @PsiACE @xyjixyjixyji