Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): nodejs binding publish dry run #3632

Merged
merged 7 commits into from
Nov 22, 2023
Merged

chore(ci): nodejs binding publish dry run #3632

merged 7 commits into from
Nov 22, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Nov 20, 2023

This pr adds a publish dry run for the nodejs binding.

@suyanhanx
Copy link
Member Author

suyanhanx commented Nov 20, 2023

Requesting an update to execute cargo update and update the jsonwebtoken in reqsign to 9, to remove the ring@0.16.20 in our cargo.lock. This outdated crate is having trouble compiling on aarch64 win, and I can't fix this problem.
image
In fact, there is no ring@0.16.20 in rustls@0.21.9. The only one is imported by the jsonwebtoken in reqsign.

Other crates are using ring@0.17.5, which doesn't have a compiling problem.
cc @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

The only one is imported by the jsonwebtoken in reqsign.

We used to upgrade jsonwebtoken in reqsign to but failed for introducing two different version of ring which is not released in rustls.

Since https://github.com/rustls/rustls/releases/tag/v%2F0.21.8 has been released, it's time for us to try again.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

#3644 should fix the issue around reqsign.

But due to async-rs/async-tls#55, services-ftp is still blocked on old rustls. I think we can remove it from bindings (for java/nodejs/python) until it has been resolved.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
Copy link
Member Author

suyanhanx commented Nov 22, 2023

image
Now they are all compiled and publish dry run successfully.

Thank you. @Xuanwo

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review November 22, 2023 14:13
.github/workflows/bindings_nodejs.yml Show resolved Hide resolved
bindings/nodejs/upgrade.md Outdated Show resolved Hide resolved
bindings/nodejs/upgrade.md Outdated Show resolved Hide resolved
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo Xuanwo merged commit be0853e into main Nov 22, 2023
34 checks passed
@Xuanwo Xuanwo deleted the rc-publish-dry-run branch November 22, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants