Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dry run publish on rc tags for python binding #3645

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

everpcpc
Copy link
Contributor

@everpcpc everpcpc commented Nov 22, 2023

pypa/gh-action-pypi-publish dose not have a dryrun option, so we just list package files.

cc @suyanhanx

@everpcpc everpcpc changed the title ci: dry run on rc tags for python & nodejs binding ci: dry run publish on rc tags for python & nodejs binding Nov 22, 2023
@suyanhanx
Copy link
Member

suyanhanx commented Nov 22, 2023

Thans for your work! But I'm sorry. I'm working on the nodejs part in #3632. Could you please remove them?

@everpcpc everpcpc changed the title ci: dry run publish on rc tags for python & nodejs binding ci: dry run publish on rc tags for python binding Nov 22, 2023
@suyanhanx
Copy link
Member

Maybe we could try to publish python bindng to here https://test.pypi.org/ as dry run?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Xuanwo Xuanwo merged commit 0b3505b into apache:main Nov 22, 2023
12 checks passed
@everpcpc everpcpc deleted the fix-dryrun branch November 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants